Add international vault listings - #1294
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Non-USD vaults need a dedicated listing and detail-page handling so their TVL is shown consistently in USD while still exposing the denomination and native currency context. The existing pages treated some non-USD vault NAV values as already-dollar-denominated or skipped conversion when the backend supplied an empty denomination rate object.
Lessons learnt
Git worktrees do not copy ignored local files such as
.env.localanddata/, so private vault chart data can fail locally even when the main checkout works. The new worktree documentation records the required env and data symlink setup.EURCV metadata may not have its own USD rate, so the frontend needs to infer the native currency and use stablecoin metadata fallback rates. Empty
denomination_token_rateobjects should not block that enrichment.Summary